next-auth icon indicating copy to clipboard operation
next-auth copied to clipboard

feat: use `NodeNext` module resolution

Open balazsorban44 opened this issue 1 year ago • 3 comments

TODO

Related: https://github.com/nextauthjs/next-auth/issues/9917, https://github.com/nextauthjs/next-auth/issues/9883, https://github.com/nextauthjs/next-auth/issues/9844 and more...

balazsorban44 avatar Feb 07 '24 22:02 balazsorban44

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 11:10am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 11:10am
nextra-docs ⬜️ Ignored (Inspect) Jun 1, 2024 11:10am
proxy ⬜️ Ignored (Inspect) Visit Preview Jun 1, 2024 11:10am

vercel[bot] avatar Feb 07 '24 22:02 vercel[bot]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@actions/[email protected] environment, filesystem Transitive: network, unsafe +17 8.12 MB thboop
npm/@auth/[email protected] environment +1 566 kB balazsorban
npm/@auth/[email protected] Transitive: network +3 793 kB balazsorban
npm/@sveltejs/[email protected] environment +1 84.2 kB svelte-admin
npm/@sveltejs/[email protected] environment, eval Transitive: filesystem +15 1.47 MB svelte-admin
npm/@sveltejs/[email protected] Transitive: environment +8 798 kB svelte-admin
npm/@types/[email protected] None +9 107 kB types
npm/@types/[email protected] None 0 13.9 kB types
npm/@types/[email protected] None 0 3.99 MB types
npm/[email protected] network Transitive: environment, eval, filesystem, shell, unsafe +133 9.62 MB stevenvachon
npm/[email protected] environment, filesystem, network Transitive: eval, unsafe +59 2.05 MB wesleytodd
npm/[email protected] eval Transitive: environment, filesystem, network +8 181 kB dougwilson
npm/[email protected] environment, eval, filesystem +43 6.46 MB pug-bot
npm/[email protected] Transitive: environment, eval, filesystem, unsafe +31 10.5 MB svelte-language-tools-deploy
npm/[email protected] Transitive: unsafe +17 6.31 MB svelte-admin
npm/[email protected] environment, eval, filesystem Transitive: shell, unsafe +40 6.34 MB egoist
npm/[email protected] Transitive: filesystem, unsafe +1 495 kB hirokiosame
npm/[email protected] Transitive: environment, filesystem, network, shell, unsafe +3 630 kB hirokiosame
npm/[email protected] None 0 32 MB typescript-bot
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +3 6.01 MB vitebot

🚮 Removed packages: npm/@graphql-typed-document-node/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

socket-security[bot] avatar Feb 07 '24 22:02 socket-security[bot]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security[bot] avatar Feb 07 '24 22:02 socket-security[bot]

Fixed up a few small things, but theres still a lingering build issue apparently. See the Build step output in this job.

Looks like it can't find the types imported from @simplewebauthn/server/script/deps. In my local installation though, node_modules/@simplewebauthn/server/script/deps.d.ts definitely does export the types we're trying to import :thinking:

Changing the imports to add a .js or .d.ts extension doesn't seem to help

image

ndom91 avatar May 14 '24 10:05 ndom91

Looks like there's a separate @simplewebauthn/types package that they publish which exports all the required types we needed

ndom91 avatar May 21 '24 15:05 ndom91

@balazsorban44 Xata had some larger issues, I updated the pkg and updated the affected types. Tested it with a Xata project manually and it all seems to work still :crossed_fingers:

Dgraph and @simplewebauthn just needed some smaller TS fixes to build again, but those are working now too. The whole thing builds again now. Imo good to merge!

ndom91 avatar May 21 '24 15:05 ndom91

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 40.75%. Comparing base (0b321a0) to head (39cc6cf).

Files Patch % Lines
packages/core/src/lib/utils/webauthn-client.js 18.75% 13 Missing :warning:
packages/next-auth/src/lib/types.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9953      +/-   ##
==========================================
- Coverage   40.75%   40.75%   -0.01%     
==========================================
  Files         177      177              
  Lines       28031    28038       +7     
  Branches     1244     1244              
==========================================
+ Hits        11424    11426       +2     
- Misses      16607    16612       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 01 '24 11:06 codecov[bot]