terraform-provider-newrelic icon indicating copy to clipboard operation
terraform-provider-newrelic copied to clipboard

feat(cloud-integrations): Add GCP and AWS cloud integrations

Open abasha1234 opened this issue 1 year ago • 2 comments

This PR will add Integrations GcpAiPlatform, AwsMsElasticache to Cloud Integration Resources

Ticket: NR-266295

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • [ ] My commit message follows conventional commits
  • [ ] My code is formatted to Go standards
  • [ ] I have performed a self-review of my own code
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

abasha1234 avatar May 21 '24 21:05 abasha1234

great job with this @abasha1234. Will shortly take a look at this PR.

pranav-new-relic avatar May 22 '24 04:05 pranav-new-relic

Codecov Report

Attention: Patch coverage is 27.27273% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 32.85%. Comparing base (92361de) to head (7890cb1). Report is 22 commits behind head on main.

Files Patch % Lines
...wrelic/resource_newrelic_cloud_gcp_integrations.go 27.27% 32 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2669      +/-   ##
==========================================
+ Coverage   32.82%   32.85%   +0.03%     
==========================================
  Files          98       98              
  Lines       26884    27494     +610     
==========================================
+ Hits         8824     9034     +210     
- Misses      17902    18299     +397     
- Partials      158      161       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 23 '24 14:05 codecov-commenter