newrelic-ruby-agent
newrelic-ruby-agent copied to clipboard
rake multiverse:clobber - needs Postgres support and needs better rescuing
Description
The multiverse tests offer rake multiverse clobber for cleanup. There are two problems with that task:
- Postgres tests have been added, but the task still only drops MySQL databases.
- Exceptions thrown by the current MySQL database drop operations should be rescued individually, but currently they are erroneously caught with a single
rescuethat states that there was a problem with the listing of the databases instead of with the dropping of them (seeremove_local_multiverse_databasesinlib/tasks/multiverse.rb
Expected Behavior
- Postgres databases should be dropped by the clobber task
- Exceptions related to the dropping of a database should not be incorrectly reported as issues with listing databases.
Troubleshooting or NR Diag results
Provide any other relevant log data. TIP: Scrub logs and diagnostic information for sensitive information n/a
Steps to Reproduce
Please be as specific as possible. TIP: Link a sample application that demonstrates the issue.
- Run the task after running a Postgres suite that creates (a) Postgres database(s)
- Fake an exception with MySQL database dropping
Your Environment
Include as many relevant details about your environment as possible including the running version of the Ruby agent, the Ruby version being used and any other relevant environment information (all)
Additional context
Add any other context about the problem here. For example, relevant community posts or support tickets. n/a
https://issues.newrelic.com/browse/NEWRELIC-3420