newrelic-ruby-agent icon indicating copy to clipboard operation
newrelic-ruby-agent copied to clipboard

Use double splat for Ruby >= 3.0

Open patrickarnett opened this issue 1 year ago • 1 comments

Overview

Kafka::Consumer#each_message takes keyword arguments. In Ruby >= 3.0, prepending it with a method that takes only positional arguments causes an ArgumentError when calling super.

Reviewer Checklist

  • [ ] Perform code review
  • [ ] Add performance label
  • [ ] Perform appropriate level of performance testing
  • [ ] Confirm all checks passed
  • [ ] Add version label prior to acceptance

patrickarnett avatar Oct 17 '24 05:10 patrickarnett

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 17 '24 05:10 CLAassistant

@tannalynn any ideas on when this will land in a patch release? We recently ran into this when updating to 9.14.0. Thanks!

gfmurphy avatar Oct 29 '24 15:10 gfmurphy

@gfmurphy Thanks for checking in on this! We plan on releasing this fix later this week, as 9.15.0. Hopefully that helps!

tannalynn avatar Oct 30 '24 16:10 tannalynn