k8s-metadata-injection icon indicating copy to clipboard operation
k8s-metadata-injection copied to clipboard

fix: Propagate global tolerations to webhook jobs

Open chernetskyi opened this issue 1 week ago • 1 comments
trafficstars

Description

Tolerations set via global.tolerations in nri-bundle did not propagate to the Jobs created by this chart.

Type of change

  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] New feature / enhancement (non-breaking change which adds functionality)
  • [ ] Security fix
  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ ] Add changelog entry following the contributing guide
  • [ ] Documentation has been updated
  • [ ] This change requires changes in testing:
    • [ ] unit tests
    • [ ] E2E tests

chernetskyi avatar Nov 13 '25 10:11 chernetskyi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 13 '25 10:11 CLAassistant

Hi @chernetskyi, Thank you for your PR! To merge this PR, we're going to need additional unit tests added that cover the new functionality. You can find details on the library we use here. Thank you!

dbudziwojskiNR avatar Nov 17 '25 17:11 dbudziwojskiNR

Hello @dbudziwojskiNR, I've added the unit test and changelog entry. Please review.

Unrelated: the relative link to the contributing guide in the PR template does not work from the PRs.

chernetskyi avatar Nov 17 '25 19:11 chernetskyi

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 49.35%. Comparing base (74d505a) to head (65a67aa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #668      +/-   ##
==========================================
- Coverage   50.17%   49.35%   -0.82%     
==========================================
  Files           3        3              
  Lines         287      233      -54     
==========================================
- Hits          144      115      -29     
+ Misses        135      110      -25     
  Partials        8        8              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 17 '25 21:11 codecov[bot]