helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Remove resources cpu limits default (newrelic-logging)

Open ciechonp opened this issue 1 year ago • 1 comments

Description

We would like to remove cpu limits default from newrelic-logging helm chart as it is best practise for setting resources. It is also preventing us for doing so as we are using nri-bundle helm chart and because of helm bug related to dependent helm charts it is impossible to remove it. https://github.com/newrelic/helm-charts/blob/master/charts/newrelic-logging/values.yaml#L248

Acceptance Criteria

Remove cpu limit from newrelic-logging helm chart defaults

ciechonp avatar May 27 '24 10:05 ciechonp

https://new-relic.atlassian.net/browse/NR-273815

@ciechonp This fix is scheduled to be in Helm 3.17.1 👍 See https://github.com/helm/helm/pull/12879#issuecomment-2616724718

scottrigby avatar Jan 27 '25 21:01 scottrigby

Resolution for Vendor Review Dev project