nrn
nrn copied to clipboard
Add RxDExceptions to invalid arguments in _ensure_arithmeticed
Closes #2892
✔️ e4dd966e125ef73294d3aaf37c3fea948d24d227 -> Azure artifacts URL
Logfiles from GitLab pipeline #214252 (:no_entry:) have been uploaded here!
Status and direct links:
- :no_entry: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
✔️ b17da756e3ff64a4fe499e8c2923149e47d68211 -> Azure artifacts URL
✔️ 61f4eb23f7a1de15f2c8737766ab0ce62ab8a905 -> Azure artifacts URL
Logfiles from GitLab pipeline #214279 (:no_entry:) have been uploaded here!
Status and direct links:
- :no_entry: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
✔️ 5b816734a229a4bdd3b20f79cd0a9216157a03d7 -> Azure artifacts URL
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.34%. Comparing base (
78082bf) to head (893c14d).
Additional details and impacted files
@@ Coverage Diff @@
## master #2893 +/- ##
=======================================
Coverage 68.34% 68.34%
=======================================
Files 682 682
Lines 116452 116455 +3
=======================================
+ Hits 79584 79587 +3
Misses 36868 36868
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Logfiles from GitLab pipeline #214299 (:white_check_mark:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
Logfiles from GitLab pipeline #217294 (:white_check_mark:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
✔️ 3da97d434558d0144beda97d2c7a934ee2683334 -> Azure artifacts URL
✔️ 0f304cda6edf24c0159054e21abca9c571d1ed80 -> Azure artifacts URL
Logfiles from GitLab pipeline #217760 (:no_entry:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:omp
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
✔️ 89fbbebe74c143ddf78f8ef509be1b13425c7461 -> Azure artifacts URL
Does anyone have any intuition (1) why the data type would be reported as different on macOS with Python 3.12 than on everything else? Bonus: it reports as exactly what it should be, but isinstance fails. (2) Why librxdmath would be built for a newer macOS version than used in the CI? That just seems like it's asking for trouble.
@adamjhn @nrnhines @pramodk
Logfiles from GitLab pipeline #218747 (:no_entry:) have been uploaded here!
Status and direct links:
- :white_check_mark: mac_m1_cmake_build: [cmake, ON, OFF, OFF, address]
- :white_check_mark: spack_setup
- :white_check_mark: build:nmodl
- :white_check_mark: build:neuron:nmodl:intel:legacy
- :white_check_mark: build:neuron:nmodl:intel:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: build:neuron:nmodl:nvhpc:omp:legacy
- :white_check_mark: build:neuron:nmodl:nvhpc:omp
- :white_check_mark: test:neuron:nmodl:intel:legacy
- :white_check_mark: test:neuron:nmodl:intel:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:legacy
- :white_check_mark: test:neuron:nmodl:nvhpc:acc:shared
- :white_check_mark: test:neuron:nmodl:nvhpc:omp:legacy
- :no_entry: test:neuron:nmodl:nvhpc:omp
@ramcdougal: I don't have an idea for (1) but for (2) created https://github.com/neuronsimulator/nrn/pull/2944. I didn't check much details but I assume (2) is not causing any failures.
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
✔️ fac6cb07ccbf23901f5ab7de4938d09d334a71d2 -> Azure artifacts URL
✔️ 3cfa7485040d0d17d64aa919db60a912db627a72 -> Azure artifacts URL
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
✔️ 893c14d6c02d33ad91bd256fd263d9f02652adc6 -> Azure artifacts URL