nrn icon indicating copy to clipboard operation
nrn copied to clipboard

Add RxDExceptions to invalid arguments in _ensure_arithmeticed

Open rgourdine opened this issue 1 year ago • 22 comments

Closes #2892

rgourdine avatar May 31 '24 21:05 rgourdine

✔️ e4dd966e125ef73294d3aaf37c3fea948d24d227 -> Azure artifacts URL

azure-pipelines[bot] avatar May 31 '24 22:05 azure-pipelines[bot]

✔️ b17da756e3ff64a4fe499e8c2923149e47d68211 -> Azure artifacts URL

azure-pipelines[bot] avatar Jun 01 '24 04:06 azure-pipelines[bot]

✔️ 61f4eb23f7a1de15f2c8737766ab0ce62ab8a905 -> Azure artifacts URL

azure-pipelines[bot] avatar Jun 01 '24 05:06 azure-pipelines[bot]

✔️ 5b816734a229a4bdd3b20f79cd0a9216157a03d7 -> Azure artifacts URL

azure-pipelines[bot] avatar Jun 01 '24 15:06 azure-pipelines[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.34%. Comparing base (78082bf) to head (893c14d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2893   +/-   ##
=======================================
  Coverage   68.34%   68.34%           
=======================================
  Files         682      682           
  Lines      116452   116455    +3     
=======================================
+ Hits        79584    79587    +3     
  Misses      36868    36868           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 01 '24 16:06 codecov[bot]

✔️ 3da97d434558d0144beda97d2c7a934ee2683334 -> Azure artifacts URL

azure-pipelines[bot] avatar Jun 17 '24 13:06 azure-pipelines[bot]

✔️ 0f304cda6edf24c0159054e21abca9c571d1ed80 -> Azure artifacts URL

azure-pipelines[bot] avatar Jun 18 '24 22:06 azure-pipelines[bot]

✔️ 89fbbebe74c143ddf78f8ef509be1b13425c7461 -> Azure artifacts URL

azure-pipelines[bot] avatar Jun 25 '24 13:06 azure-pipelines[bot]

Does anyone have any intuition (1) why the data type would be reported as different on macOS with Python 3.12 than on everything else? Bonus: it reports as exactly what it should be, but isinstance fails. (2) Why librxdmath would be built for a newer macOS version than used in the CI? That just seems like it's asking for trouble.

@adamjhn @nrnhines @pramodk

ramcdougal avatar Jun 25 '24 14:06 ramcdougal

@ramcdougal: I don't have an idea for (1) but for (2) created https://github.com/neuronsimulator/nrn/pull/2944. I didn't check much details but I assume (2) is not causing any failures.

pramodk avatar Jun 26 '24 07:06 pramodk

✔️ fac6cb07ccbf23901f5ab7de4938d09d334a71d2 -> Azure artifacts URL

azure-pipelines[bot] avatar Sep 23 '24 18:09 azure-pipelines[bot]

✔️ 3cfa7485040d0d17d64aa919db60a912db627a72 -> Azure artifacts URL

azure-pipelines[bot] avatar Mar 28 '25 20:03 azure-pipelines[bot]

✔️ 893c14d6c02d33ad91bd256fd263d9f02652adc6 -> Azure artifacts URL

azure-pipelines[bot] avatar Apr 02 '25 19:04 azure-pipelines[bot]