scikit-tree
scikit-tree copied to clipboard
FEA Implement pruning using honest subsample data to fit the leaves
trafficstars
Changes proposed in this pull request:
- Adds honest pruning, so no empty leaves occur within the
HonestTreeClassifier
Before submitting
- [ ] I've read and followed all steps in the Making a pull request
section of the
CONTRIBUTINGdocs. - [ ] I've updated or added any relevant docstrings following the syntax described in the
Writing docstrings section of the
CONTRIBUTINGdocs. - [ ] If this PR fixes a bug, I've added a test that will fail without my fix.
- [ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.
After submitting
- [ ] All GitHub Actions jobs for my pull request have passed.
Codecov Report
Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.
Project coverage is 80.54%. Comparing base (
e1c38ad) to head (d1221e4). Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| treeple/tree/_honest_tree.py | 78.37% | 3 Missing and 5 partials :warning: |
| treeple/stats/forest.py | 0.00% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 80.50% 80.54% +0.03%
==========================================
Files 24 24
Lines 2334 2364 +30
Branches 339 343 +4
==========================================
+ Hits 1879 1904 +25
- Misses 318 319 +1
- Partials 137 141 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Merging. Thanks for the in-depth review and fixes @PSSF23 !