spinnaker_sdk_camera_driver icon indicating copy to clipboard operation
spinnaker_sdk_camera_driver copied to clipboard

Published 20 hours ago • verified publisher icon neufieldrobotics

Feature/ubuntu 20.4

Open PushyamiKaveti opened this issue 3 years ago • 5 comments
trafficstars

@mithundiddi @jpsnir Please review and merge. OpenCV update for ubuntu 20.04

PushyamiKaveti avatar Jun 16 '22 21:06 PushyamiKaveti

Why is the CI failing, it should continue working with the old versions right?

vik748 avatar Jun 16 '22 22:06 vik748

Not sure, Re-running the build.

PushyamiKaveti avatar Jun 16 '22 22:06 PushyamiKaveti

Found the issue, it is failing because travis build is happening for ubuntu < 20.04 with opencv 3.2.0 and this branch is particularly for opencv 4.x and ubuntu 20.04. We have to setup build for this configuration.

PushyamiKaveti avatar Jun 17 '22 18:06 PushyamiKaveti

One thought, all these ifdefs make it really hard to read the code. How about we reaname all the calls to the new open cv functions. Then in one place do a OpenCV version check and then assign function aliases to the old opencv functions if needed. This way there should only be 1 if def. Aliases: https://www.fluentcpp.com/2017/10/27/function-aliases-cpp/

vik748 avatar Jun 18 '22 05:06 vik748

@PushyamiKaveti @mithundiddi this should fix the issue building. Please try it out once.

vik748 avatar Jun 19 '22 05:06 vik748