light-codegen icon indicating copy to clipboard operation
light-codegen copied to clipboard

Updating Codegen Docker Images and Storage on Dockerhub

Open soaapp opened this issue 4 years ago • 5 comments

Resume the creation of codgen docker images and storage on dockerhub

soaapp avatar Mar 04 '21 20:03 soaapp

@soaapp The latest and 1.6.32 has have been released to the docker hub. Please double-check after the 1.6.33 release at the end of the month to ensure that the light-bot build will release the new version for each 1.6.x release. Thanks.

https://hub.docker.com/layers/networknt/light-codegen/1.6.32/images/sha256-6463bbd5cfacc13642066471274dc568e6593180a626bcd4d0dfb5f782f64f5b?context=repo

Let's close the issue when we see the 1.6.33 release on the docker hub.

stevehu avatar Mar 05 '21 01:03 stevehu

@stevehu I believe the 1.6.33 release was completed at the end of March but it seems the light-bot did not release for each 1.6.x. If possible, the docker image creation for 1.6.26 is required. Thank you for your help.

soaapp avatar Apr 06 '21 14:04 soaapp

Here is the 1.6.33 released by the light-bot several days ago.

https://hub.docker.com/layers/143301627/networknt/light-codegen/1.6.33/images/sha256-f0e1bdc4daf919208945f8ce676b51c5abf362da4718ee9989a757606cfcf716?context=explore

We cannot release something with a previous tag by light-bot. I am wondering if you could upgrade your tutorial with 1.6.33 tag.

stevehu avatar Apr 06 '21 15:04 stevehu

It currently need 1.6.26 as that is the versioning we support for it. Is there anyway that image can be added as well?

soaapp avatar Apr 06 '21 16:04 soaapp

@soaapp I checked the Dockerfile and it uses the latest code from the 1.6.x branch, not from the tag. We cannot go back to the time to build the docker image without a customized Dockerfile to do so.

https://github.com/networknt/light-docker/blob/1.6.x/light-codegen/Dockerfile#L9

If you look at the 1.6.26 release, we do have the codegen-cli.jar attached. You can use that jar file to build a customized docker image and publish it to your internal docker registry. If you want to publish to the public docker hub, please submit a PR in the light-docker and I can run it to publish to networknt.

https://github.com/networknt/light-codegen/releases/tag/1.6.26

stevehu avatar Apr 06 '21 22:04 stevehu