next-runtime
next-runtime copied to clipboard
[Chore]: Consolidate demo sites
This requirement for testing disabling of edge functions would necessitate another demo site and another Cypress run.
I had a look at consolidating some of the existing demo sites and cypress runs. Unfortunately, I found https://github.com/netlify/next-runtime/issues/1426 so it looks like the middleware demo needs to remain separate.
Other than that, I propose:
- [ ] remove
custom-routesdemo because the rewrite/redirect functionality in here is already demonstrated indefaultand this site is not tested with Cypress - [ ] remove
next-with-edge-functionsdemo because this is already tested implicitly with the functionality inmiddlewareand this site is not tested with Cypress - [ ] remove
next-i18nextdemo because the i18n functionality is already tested instatic-rootand this site is not tested with Cypress - [ ] rename
static-roottoi18nbecause it only seems to demo/test i18n functionality (unless I'm missing something... what does static root mean?)
The custom-routes demo is mainly testing the redirects, rewrites and headers. It's one that's taken from the next.js monorepo's own e2e tests. I'm using it for the edge router dev. We might want to turn it off for deploy previews and just enable it on that branch.
The static-root one is testing having a static file as /, but that can probably be either removed or merged with something else.
I think we might still want to move the middleware demo into the default demo. The static manifest should be testable with unit tests.
remove next-i18next demo because the i18n functionality is already tested in static-root and this site is not tested with Cypress
The first part of this is incorrect (static-root does not use the "next-i18next" dependency in package.json, or have a demos/next-i18next/next-i18next.config.js file.
Closing as duplicate https://github.com/netlify/pod-ecosystem-frameworks/issues/456