cli icon indicating copy to clipboard operation
cli copied to clipboard

Published 20 hours ago • verified publisher icon netlify

fix: Update edge-bundler and ensure only allowed environment variables are supplied to edge functions

Open danez opened this issue 3 years ago • 1 comments

Summary

Fixes #4614

This adds the environment variables from the ui and the two DENO environment variables for edge-functions.

danez avatar Aug 10 '22 11:08 danez

📊 Benchmark results

Comparing with 868ec26799bc1ae506c4421a579e30cab37266a8

Package size: 228 MB

⬆️ 0.01% increase vs. 868ec26799bc1ae506c4421a579e30cab37266a8

^  230 MB  230 MB  230 MB  230 MB  228 MB  228 MB  228 MB  228 MB  228 MB  228 MB  228 MB  228 MB  228 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T
Legend
  • T-30 (cad6c6010650a7041380ee71da82bcbfefaddc78): 224 MB
  • T-29 (5e23b25d8d20a7f035a94398297b48bec68be661): 224 MB
  • T-28 (d2e572a328fc9e0e9462506a73bcf502a252fb44): 224 MB
  • T-27 (2f11b279369eec39ed2dbe84ed444cb0ded1eeb0): 224 MB
  • T-26 (6da32afacf9cff72c80880df876b4f427ce2ce52): 224 MB
  • T-25 (dad8d9a57dee3c1e0bd2ed417e1dcee18866ecdb): 224 MB
  • T-24 (a04bc102c4485037ee5845ebe01a1fe8d3e55a5a): 224 MB
  • T-23 (20fa2b286b5cb5eb134630827c6fbee02b69aa1a): 224 MB
  • T-22 (f83a930add5b1ada8ae79ad8f494841556d1567d): 230 MB
  • T-21 (64789d0c133a55b48f74e95b845ced2d07e1a864): 230 MB
  • T-20 (8933bfb2b0b53d14a6d5532a1ad6c851842e64d8): 230 MB
  • T-19 (b98a4de807a2fa23addb9a7a32c35672eaecd16e): 230 MB
  • T-18 (61ba1ef4f263fe40b6c2b4bc186f55738e344be0): 230 MB
  • T-17 (7203fe5a13bad715863af2119f8488a10681c2ec): 230 MB
  • T-16 (22ac96087bb5ae39c1280b7c317a1ca78cafef31): 230 MB
  • T-15 (ca1c17fea2e8c98e4fe1fda5c6c2fb663fe46ed7): 230 MB
  • T-14 (b3dc89711e736d581b58ec55bae7d843894a6dfd): 230 MB
  • T-13 (ad84a4651f3da2c805e738dbafd4c9a869d59d77): 230 MB
  • T-12 (73d9a6e9c00ba5b056ee27406b0f4e107c192622): 230 MB
  • T-11 (c38d2de4d4a1d81db5052897f8d907d1deee4b1d): 230 MB
  • T-10 (490333a1ab09ae701566815ded1b30c3c1195f78): 230 MB
  • T-9 (08652bb3b74e9419ed6bb62a9627cb7c5cd88428): 230 MB
  • T-8 (4a6cb0e6f1aec54b74c1b70678ba0ceaf1b5c08a): 228 MB
  • T-7 (f02d08e2f86064322547b416dec51ea1d16987fa): 228 MB
  • T-6 (64e48dcd3440e137fb9d6d88f4bc1473878af304): 228 MB
  • T-5 (7c209cbd0bb6480a0f09444ce49c64eb6711f5da): 228 MB
  • T-4 (f362ec752e805323ae26c3c633d7f5920b88498b): 228 MB
  • T-3 (585d91e597420bd40d6240f2f02c9623ba6bd99c): 228 MB
  • T-2 (91f4ab26087319c1df411cabf108dcee712153d5): 228 MB
  • T-1 (868ec26799bc1ae506c4421a579e30cab37266a8): 228 MB
  • T (current commit): 228 MB

github-actions[bot] avatar Aug 10 '22 11:08 github-actions[bot]

I just remembered that this is used in the bootstrap layer to detect whether we're running in production or not (see https://github.com/netlify/edge-functions-bootstrap/blob/main/src/bootstrap/environment.ts#L2).

For non-Netlify employees: https://github.com/mlafeldt/netlify-edge-bootstrap/blob/main/modules/edge-bootstrap.netlify.app/bootstrap/environment.ts#L2 😄

Are you ever going to make that repo public?

mlafeldt avatar Aug 11 '22 15:08 mlafeldt