Device-Type-Library-Import icon indicating copy to clipboard operation
Device-Type-Library-Import copied to clipboard

Script replaces seemingly random existing images with each run

Open st-nip opened this issue 2 years ago • 2 comments

With one run, the script will create new device types, but then on subsequent runs it seems to overwrite device images with a new name, then the next sometimes it'll do the same again, and again.

Example: device type EMAT09-10

First run:

Difference

{ "front_image": "" }

{ "front_image": "devicetype-images/eaton-emat09-10.front.png" }

Second run:

Difference

{ "front_image": "devicetype-images/eaton-emat09-10.front.png" }

{ "front_image": "devicetype-images/eaton-emat09-10.front_8zE6qHf.png" }

Third run:

Difference

{ "front_image": "devicetype-images/eaton-emat09-10.front.png" }

{ "front_image": "devicetype-images/eaton-emat09-10.front_KCjLwwE.png" }

Of course, this is completely unnecessary and no doubt is filling up storage with random new images. I'm just wondering - why does the script even overwrite images in the first place? Surely it's enough to upload them once.

I pulled the version of the script down yesterday, so it's a current issue.

st-nip avatar Sep 20 '23 05:09 st-nip

Can confirm, seemingly pointless image updates at random.

image

Azmodeszer avatar Sep 26 '23 07:09 Azmodeszer

This is done automatically by the Netbox API. You can manually recreate this by uploading an image file with the same name as the existing image file for a device type image. It will automatically append something to make the name unique.

Perhaps the solution here is to have a flag that forces overwriting existing images instead of always overwriting.

qspark-eliezerlp avatar Aug 22 '24 01:08 qspark-eliezerlp