crud icon indicating copy to clipboard operation
crud copied to clipboard

Future of the library

Open hakimio opened this issue 4 years ago • 30 comments

@zMotivat0r do you plan to maintain this library? Is it worth starting new integrations (ie mikro-orm, firestore, sequelize, mongoose)? Do you have some plan what you'd like to do with the library?

hakimio avatar May 26 '21 13:05 hakimio

I am tempted to fork it and merge all the fixes that everyone is waiting on, but it would be better to be able to help to develop this library on this repo.

Can I become a contributor?

https://twitter.com/rewiko/status/1399790684031406080

rewiko avatar Jun 01 '21 18:06 rewiko

I kind of thought this would eventually go into the Nestjs organization. Im interested in the future of this package as well.

Jtosbornex avatar Jun 01 '21 19:06 Jtosbornex

@Jtosbornex Since @zMotivat0r just recently joined "Trilon" (the company behind NestJS) and there is a lot of interest in the library from the community, I think it's quite possible of it becoming part of official NestJS organization.

hakimio avatar Jun 01 '21 19:06 hakimio

@hakimio Really hope so. This is a great library!

mcelearr avatar Jun 03 '21 08:06 mcelearr

Hi guys! Thanks a lot for raising this issue and I would definitely love to have you guys (or some of you who may be really interested) as maintainers of this library. I really appreciate this and hope with your help we won't let this lib just die. Due to some really complex family conditions, I can't afford to spend as much time on it as I did in the past, but I don't want to completely bury this lib. So, yeah @rewiko your propositions came out with just perfect timing.

michaelyali avatar Jun 03 '21 09:06 michaelyali

Going forward, I've raised some amount of money via open collective and hadn't spend anything, so I definitely would love to share those with new maintainers as well

michaelyali avatar Jun 03 '21 09:06 michaelyali

@zMotivat0r what do you think about the idea of making this library part of NestJS organization (if @kamilmysliwiec accepts)?

hakimio avatar Jun 03 '21 09:06 hakimio

@hakimio we had a conversation about it (a couple of times tbh) and a strong argument against adding it to NestJs (and I totally agree with it) is that this lib is not totally following community convention on how to provide this kinda functionality. I.e. I build it to use @Crud decorator and pass all the params there in the first place, but another and perhaps the best way to do it to use mixins. So maybe when we have mixins, plus CrudModule with forRoot with global config instead of what we have now, plus CrudModule with forFeature for controllers auto-generation or just a per-module configuration, then we could make another proposal to @kamilmysliwiec :)

michaelyali avatar Jun 03 '21 09:06 michaelyali

Thanks @zMotivat0r for getting back to us, hope your family is ok and your problems are going to be resolved.

Happy to spend some time to at least create a new release with all the bug fixes waiting to be merged.

rewiko avatar Jun 03 '21 10:06 rewiko

@rewiko added you as a maintainer

michaelyali avatar Jun 03 '21 10:06 michaelyali

@zMotivat0r mixin idea theoretically seems really good, but in practice there seems to be some issues implementing it. If those could be solved, I would love to use mixin approach as well.

OT: right now all the ORM (type-orm, mikro-orm, mongoose, etc) integrations have to be added to this repository since some "core" logic is not accessible otherwise. What do you think about splitting integration core code and the integration itself into separate packages, so that people could maintain their integrations in 3rd party repositories independent from the core library?

hakimio avatar Jun 03 '21 10:06 hakimio

BTW, it might make sense to make @Diluka collaborator of this repository since he contributed a lot of code already.

hakimio avatar Jun 03 '21 10:06 hakimio

This is a great NestJS library and it would be wonderful to see it at least maintained. I would be happy to help out. I use it on some production projects and it is really super helpful!

rogyvoje avatar Jun 14 '21 17:06 rogyvoje

@zMotivat0r I would be happy to contribute.

Maybe we could start by creating a package roadmap in Github Projects.

tarekbazine avatar Jun 23 '21 12:06 tarekbazine

@rewiko any updates regarding reanimating the package ?

tarekbazine avatar Jul 02 '21 12:07 tarekbazine

I can merge PR, but I don't know how to create a new release (new credentials..), I asked @zMotivat0r we would potentially use mrepo to automate the release process.

rewiko avatar Jul 02 '21 12:07 rewiko

mrepo

May I propose using https://github.com/atlassian/changesets for managing releases?

Bnaya avatar Jul 09 '21 16:07 Bnaya

@rewiko Please any updates on this thread ?

there are a lot of pending PRs

some of are just silly things for ex: I have // @ts-ignore all over my controllers in

@Crud({
    // ....
    join: {
      xxxxx: {
        // @ts-ignore <-------------
        select: true,
        eager: true,
      },

just because of the type https://github.com/nestjsx/crud/pull/713

and so one ...

so Please would you put time into it or let who is interrested to do so,

thank you for understanding, and for the good job, we are just caring about the package to not die

tarekbazine avatar Aug 03 '21 08:08 tarekbazine

@tarekbazine @rewiko as mentioned above doesn't have permissions to create new releases.

hakimio avatar Aug 03 '21 08:08 hakimio

@hakimio I do not see the permissions thing mentioned in the thread, but even though we need to solve this since the package is inactive since months.

any suggestion ? we maintain a fork ? @rewiko @zMotivat0r

tarekbazine avatar Aug 03 '21 14:08 tarekbazine

Any updates on this? What is the problem with the releases @rewiko? Is it a permissions thing or just choosing the right tool?

@zMotivat0r can you please help him with this? I'm also offering to help out if you need me. This is a great library and would be a shame for it to die over this.

mcelearr avatar Sep 17 '21 07:09 mcelearr

Please! any update on this? people are offering to help

we just need to know what is the blocker here.

tarekbazine avatar Nov 12 '21 12:11 tarekbazine

This library is a crucial part of my stack and one of the most important modules for any Nest.js REST API. It'd be amazing to have this resolved asap, I'd be willing to support this also financially if it gains momentum again.

0x7061 avatar Nov 15 '21 15:11 0x7061

Any progress? What's the blocker currently?

0x7061 avatar Nov 27 '21 10:11 0x7061

Looks like @zMotivat0r just gave up on this library and there won't be any further development.

hakimio avatar Nov 27 '21 10:11 hakimio

Shall we fork this then? There are so many valuable PRs out there...

0x7061 avatar Nov 27 '21 10:11 0x7061

I also want to help, @zMotivat0r gave me access to the repo so I can merge PR, but I do not have access to the NPM repo to publish the lib (the release is not automated). I spoke to @zMotivat0r 6 month ago, and he was keen to automate the release with https://github.com/zMotivat0r/mrepo.

I think we should try to automate the release, I guess for now we should fork it, automate the release and merge all the valuable PRs.

@codepushr would you be happy to help ? (I will spend time too)

rewiko avatar Nov 27 '21 11:11 rewiko

I managed to migrate and publish the lib under my username on npm and github. I am happy to create a generic repo if needed otherwise, we can migrate PR and merge them.

list of PR merged https://github.com/rewiko/crud/issues/5

rewiko avatar Nov 27 '21 13:11 rewiko

@rewiko Thank you very much. Please keep up the good work. IMO you can continue merging PR while trying to contact @zMotivat0r for deployment access. I still want to see a new version of this package under its original name as we don't want the users of this lib fragmented.

duongleh avatar Dec 04 '21 13:12 duongleh

Maybe the development of this essential package could continue here?

https://github.com/gid-oss/dataui-nestjs-crud

afilp avatar Nov 01 '23 21:11 afilp