nest icon indicating copy to clipboard operation
nest copied to clipboard

refactor(core,express,fastify): HTTP adapter error mapping

Open maxbronnikov10 opened this issue 6 months ago • 1 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes

What is the current behavior?

FastifyError instance did not mapped to HttpException which broke conditions in ExceptionFilter in core package.

Issue Number: #15022

What is the new behavior?

Added mapping function to abstract http adapter that overrided in express and fastify

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

maxbronnikov10 avatar May 05 '25 21:05 maxbronnikov10

Pull Request Test Coverage Report for Build 8f9992ff-9783-48dd-888a-83dfed01bbc7

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 88.931%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/router/routes-resolver.ts 0 1 0.0%
<!-- Total: 0 1
Totals Coverage Status
Change from base Build 0ff12a80-22b7-43a2-8e8a-1d5a5d5d96fc: -0.007%
Covered Lines: 7191
Relevant Lines: 8086

💛 - Coveralls

coveralls avatar May 05 '25 21:05 coveralls