nest icon indicating copy to clipboard operation
nest copied to clipboard

chore(deps): upgrade to express v5, fastify v5, add legacy route path converter

Open kamilmysliwiec opened this issue 11 months ago • 1 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

kamilmysliwiec avatar Nov 28 '24 10:11 kamilmysliwiec

Pull Request Test Coverage Report for Build 0a814cf0-29c6-4dee-8874-62bc2189010f

Details

  • 31 of 42 (73.81%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.757%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/middleware/utils.ts 7 10 70.0%
packages/core/router/legacy-route-converter.ts 17 21 80.95%
packages/core/router/router-explorer.ts 6 10 60.0%
<!-- Total: 31 42
Totals Coverage Status
Change from base Build cab6d4a2-2a29-4d37-84b8-35b7d0e3fb15: -0.1%
Covered Lines: 7098
Relevant Lines: 7908

💛 - Coveralls

coveralls avatar Nov 28 '24 10:11 coveralls

@kamilmysliwiec Does this unblock: https://github.com/nestjs/serve-static/issues/1513#issuecomment-2505828287 ? Thank you

cwebb612 avatar Jan 10 '25 14:01 cwebb612