nest icon indicating copy to clipboard operation
nest copied to clipboard

fix(grpc-loader): add new options by generic props loader

Open wrspada02 opened this issue 1 year ago • 4 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Other... Please describe:

What is the current behavior?

The current grpc loader options for custom options has type any.

Issue Number: #13930

What is the new behavior?

This PR allows to pass generic type to the grpc loader options, and then, the custom options provided starts having type safety.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

wrspada02 avatar Sep 03 '24 14:09 wrspada02