nest fix(core): when using forward references on `exports` array

fix(core): when using forward references on `exports` array

Open micalevisk opened this issue 1 year ago • 1 comments

trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

the following code triggers the error because of the forwardRef on exports array

import { Module, forwardRef } from '@nestjs/common';

@Module({})
export class FooModule {}

@Module({
  imports: [
    forwardRef(() => FooModule),
  ],
  exports: [forwardRef(() => FooModule)],
})
export class AppModule {}

Which breaks the ConditionModule from @nestjs/config when we use a forward reference.

Do note that the same error happens when we supply a promise to exports:

but I didn't address this error in this PR because I'm not sure about the error handling for rejected promises and about the right place to resolve such promise.