nest icon indicating copy to clipboard operation
nest copied to clipboard

Published 20 hours ago • verified publisher icon nestjs

Update package.json

Open ragavendra opened this issue 1 year ago • 4 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce? e2e test app.e2e-spec.ts has chai dependency which was not available in package,json.

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x ] Other... Please describe: Added chai to dev dependencies. Using 4.3.9 for chai as the latest version gives import error for expect.

What is the current behavior?

npm run test:e2e fails when running test in app.e2e-spec.ts on import { expect } from "chai"

Issue Number: N/A

What is the new behavior?

npm run test:e2e now passes.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ x] No

Other information

ragavendra avatar Jun 14 '24 01:06 ragavendra

Pull Request Test Coverage Report for Build 99eda344-75c9-4f7b-b0fe-46b7084b4540

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.207%
Totals Coverage Status
Change from base Build e18002f5-8ff6-4564-ba7e-328984ab8501: 0.0%
Covered Lines: 6744
Relevant Lines: 7314
💛 - Coveralls

coveralls avatar Jun 14 '24 01:06 coveralls

instead of installing chai, we can just drop line 3 and change those to.equal to toEqual

https://github.com/nestjs/nest/blob/851b51f4e53309ec779ba8f86f70ff912811715e/sample/19-auth-jwt/e2e/app/app.e2e-spec.ts#L3

micalevisk avatar Jun 14 '24 13:06 micalevisk

Pull Request Test Coverage Report for Build 256be342-8225-4e00-a8fe-64821a0665c7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.207%
Totals Coverage Status
Change from base Build e18002f5-8ff6-4564-ba7e-328984ab8501: 0.0%
Covered Lines: 6744
Relevant Lines: 7314
💛 - Coveralls

coveralls avatar Jun 14 '24 17:06 coveralls

instead of installing chai, we can just drop line 3 and change those to.equal to toEqual

I agree, I wonder why I didn't see it the first time and went on add it .....

we don't need to change the lock file tho

sure ....

ragavendra avatar Jun 14 '24 17:06 ragavendra