nest icon indicating copy to clipboard operation
nest copied to clipboard

chore: add public api annotation on microservices

Open Tony133 opened this issue 1 year ago • 1 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Proposal:

  • Added public api annotation (@publicApi) on microservices, in the following files: - packages/microservices/ctx-host/base-rpc.context.ts - packages/microservices/ctx-host/kafka.context.ts - packages/microservices/ctx-host/mqtt.context.ts - packages/microservices/ctx-host/nats.context.ts - packages/microservices/ctx-host/redis.context.ts - packages/microservices/ctx-host/rmq.context.ts - packages/microservices/ctx-host/tcp.context.ts - packages/microservices/record-builders/mqtt.record-builder.ts - packages/microservices/record-builders/nats.record-builder.ts - packages/microservices/record-builders/rmq.record-builder.ts - packages/microservices/server/server-grpc.ts - packages/microservices/server/server-kafka.ts - packages/microservices/server/server-mqtt.ts - packages/microservices/server/server-nats.ts - packages/microservices/server/server-redis.ts - packages/microservices/server/server-rmq.ts - packages/microservices/server/server-tcp.ts - packages/microservices/server/server.ts

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

Tony133 avatar May 05 '24 14:05 Tony133

Pull Request Test Coverage Report for Build fbf2ca6f-2312-4e67-a66b-a9099df1954c

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.124%

Totals Coverage Status
Change from base Build e56f6d99-d9bc-426a-b9ef-ed11406d7e1c: 0.0%
Covered Lines: 6737
Relevant Lines: 7313

💛 - Coveralls

coveralls avatar May 05 '24 15:05 coveralls

LGTM

kamilmysliwiec avatar May 08 '24 08:05 kamilmysliwiec