nest fix(core): auto flush logs on synchronous internal errors

fix(core): auto flush logs on synchronous internal errors

Open micalevisk opened this issue 1 year ago • 1 comments

trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: closes #13400

What is the new behavior?

For the following code

import { NestFactory } from '@nestjs/core'
import { AppModule } from './app.module' // no-op module

async function bootstrap() {
  const app = await NestFactory.create(AppModule, {
    bufferLogs: true,
    autoFlushLogs: true,
  });
  app.get('foo')
  await app.listen(3000);
}

bootstrap();

we'll see the following error: