nest
nest copied to clipboard
Сorrection of `Reflector` types
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Other... Please describe:
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Other information
closes #13383
Pull Request Test Coverage Report for Build 142de026-e7b7-41a2-bb12-e6facc2f16bd
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 92.123%
| Totals | |
|---|---|
| Change from base Build eacd3e56-4bed-4f5e-9bab-412a10335aab: | 0.0% |
| Covered Lines: | 6736 |
| Relevant Lines: | 7312 |
💛 - Coveralls
Could we add unit tests for this change?
I see that more tests need to be added for getAll and getAllAndOverride, as well as more type checks for all.
It is better for the members to do this or create a separate issue.
For those who used a decorator with transformation, the return type was unknown, and now it will become TTransformed.
Nothing will change for the others.
For those who used a decorator with transformation, the return type was
unknown, and now it will becomeTTransformed. Nothing will change for the others.
Okay, thanks for your reply :)
@AlexRMU can you please share a code snippet?
Snippet with what?