nest icon indicating copy to clipboard operation
nest copied to clipboard

feat(core): introduce different module opaque key factories

Open kamilmysliwiec opened this issue 1 year ago • 1 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

kamilmysliwiec avatar Mar 18 '24 09:03 kamilmysliwiec

Pull Request Test Coverage Report for Build 8992ffcb-4145-4cfe-b21d-217fd51a6835

Details

  • 44 of 46 (95.65%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 92.119%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/injector/compiler.ts 7 8 87.5%
packages/core/injector/container.ts 6 7 85.71%
<!-- Total: 44 46
Totals Coverage Status
Change from base Build 8e6acf8c-0eed-48d4-99cf-9df3f506aa5c: -0.05%
Covered Lines: 6744
Relevant Lines: 7321

💛 - Coveralls

coveralls avatar Mar 18 '24 09:03 coveralls