nest icon indicating copy to clipboard operation
nest copied to clipboard

feat: emit batch

Open gunb0s opened this issue 1 year ago • 5 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: #12748

What is the new behavior?

enable kafka producer to emit batch

Does this PR introduce a breaking change?

  • [v] Yes
  • [ ] No

Other information

gunb0s avatar Dec 20 '23 08:12 gunb0s

Pull Request Test Coverage Report for Build d4f0316f-3bf4-4a53-b632-eebbc32fa552

Details

  • 14 of 22 (63.64%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 92.051%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/microservices/client/client-kafka.ts 14 22 63.64%
<!-- Total: 14 22
Totals Coverage Status
Change from base Build 7ac098a9-c60b-4faa-9612-e3dbed2e2eb6: -0.05%
Covered Lines: 6728
Relevant Lines: 7309

💛 - Coveralls

coveralls avatar Dec 20 '23 08:12 coveralls

Would love to see this feature merged. Very handy for our use-case.

apparelmagic-heath avatar Jan 23 '24 20:01 apparelmagic-heath

@kamilmysliwiec Is this going to be merged, and if so, do you have any estimates for when?

And another thing, are you open to batching now? You said no here, #9455 Since you green-lighted batch producing, I need batch consuming and want to know if I should also have hope for it. I might start a PR for it if I find some free time.

bozorgmehr96 avatar Mar 11 '24 14:03 bozorgmehr96

hi all, pls consider this PR

binh-truong-tpv-mti avatar Apr 14 '24 07:04 binh-truong-tpv-mti