nest
nest copied to clipboard
fix(core): always bind global modules when scan for modules
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
- [x] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Other... Please describe:
What is the current behavior?
Issue Number: #12879
What is the new behavior?
Scanning for modules always bound for global modules,
Does this PR introduce a breaking change?
- [ ] Yes
- [ ] No
Other information
This branch is based on 9.4.3. Hence should not be merged into master.
Pull Request Test Coverage Report for Build de00f050-29aa-4a07-94cd-4a5c3beeb9b5
- 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
- 199 unchanged lines in 30 files lost coverage.
- Overall coverage increased (+0.7%) to 92.992%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| packages/core/scanner.ts | 7 | 8 | 87.5% |
| <!-- | Total: | 7 | 8 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| packages/common/pipes/file/file-type.validator.ts | 1 | 87.5% |
| packages/common/pipes/parse-enum.pipe.ts | 1 | 94.44% |
| packages/common/pipes/parse-float.pipe.ts | 1 | 92.31% |
| packages/common/pipes/parse-int.pipe.ts | 1 | 92.86% |
| packages/common/pipes/parse-uuid.pipe.ts | 1 | 94.74% |
| packages/common/pipes/validation.pipe.ts | 1 | 94.34% |
| packages/core/services/reflector.service.ts | 1 | 95.0% |
| packages/microservices/server/server-redis.ts | 1 | 97.01% |
| packages/microservices/client/client-rmq.ts | 2 | 81.42% |
| packages/platform-express/multer/interceptors/file-fields.interceptor.ts | 2 | 88.24% |
| <!-- | Total: | 199 |
| Totals | |
|---|---|
| Change from base Build 439f5e56-8568-4500-9046-115a7dca6920: | 0.7% |
| Covered Lines: | 6555 |
| Relevant Lines: | 7049 |
💛 - Coveralls
Could you create release branch for 9.x so this branch merged?
Just fyi, in case you're blocked by this change you can always use patch-package to fix this up for your project.
@5d-jh can you please rebase your branch
@micalevisk Because this pr resolves issue on v9, this pr should be merged into v9 release branch which is currently not exist.