nest icon indicating copy to clipboard operation
nest copied to clipboard

fix(common): apply options to plaintoclass in classserializerinterceptor

Open kmw14641 opened this issue 2 years ago • 2 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: Closes #12763

What is the new behavior?

options can be applied to plainToClass method too, which is needed for options like exposeDefaultValues.

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Other information

kmw14641 avatar Nov 16 '23 16:11 kmw14641

Pull Request Test Coverage Report for Build 36d8ee9e-355b-4c7c-afec-7cf9f5073e60

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.26%

Totals Coverage Status
Change from base Build 23ebebfc-1ad4-4b2b-8c07-2691151ef178: 0.0%
Covered Lines: 6687
Relevant Lines: 7248

💛 - Coveralls

coveralls avatar Nov 16 '23 16:11 coveralls

Anyway to help this get resolved?

jobcespedes avatar Feb 24 '24 02:02 jobcespedes