nest icon indicating copy to clipboard operation
nest copied to clipboard

refactor(microservices): update server properties to protected

Open barlock opened this issue 3 years ago • 1 comments
trafficstars

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/nestjs/nest/blob/master/CONTRIBUTING.md
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

TCP server and mqtt client were private so subclasses couldn't access them.

I peered through a few of the other servers and clients, this seems to follow patterns I've seen.

What is the new behavior?

downstream projects can subclass and access the server and client directly! YEY!.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

Other information

barlock avatar Oct 05 '22 21:10 barlock

Pull Request Test Coverage Report for Build c777d6b3-63c5-46f4-9d8d-3aadaf033241

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.786%

Totals Coverage Status
Change from base Build 6b637f64-9c7a-4d7b-8537-b6a8d098f58e: 0.0%
Covered Lines: 6113
Relevant Lines: 6518

💛 - Coveralls

coveralls avatar Oct 05 '22 21:10 coveralls

lgtm

kamilmysliwiec avatar Oct 21 '22 15:10 kamilmysliwiec