angular-token icon indicating copy to clipboard operation
angular-token copied to clipboard

Changing any `private` accessors to `protected` to enable customization by implementing projects

Open omboapp opened this issue 4 years ago • 0 comments
trafficstars

Changing any private accessors to protected, as we must not needlessly prevent inheritance or customization.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

Private accessors for AngularTokenService & AngularTokenInterceptor cannot be modified or accessed by any inherited class, especially with the intention of extending their behavior.

Issue Number: N/A

What is the new behavior?

No functional change. Simply allowing for AngularTokenService & AngularTokenInterceptor to be used as super classes for any derived classes. Implementing projects can now add or modify member functions or properties.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

omboapp avatar Jan 15 '21 00:01 omboapp