Andrew Lazarus

Results 55 comments of Andrew Lazarus
trafficstars

I hacked together zsh completions for rustup itself. Worth a PR? Long term solution: https://github.com/kbknapp/clap-rs should support zsh completion generation (my 2c; clap issue for bash completion generation=https://github.com/kbknapp/clap-rs/issues/376). [_rustup.txt](https://github.com/rust-lang-nursery/rustup.rs/files/375252/_rustup.txt)

Any status updates on proto2 support?

Funny. We were thinking of looking at this soon too. cc @zanker

Sorry for the delayed response! Thanks for merging. I think I have a bunch of other changes on my branch. I'll open some PRs if I think they look useful!

Ooops. I think I have a better fix for this. Let me see if I can rebase. I'll open another PR.

Is there anything blocking this PR from getting merged?

I find working with the struct fields very nice. The objects are just structs. I don't need to worry about a new API when passing the structs around. An added...

Hypothetical generated code using structs: In the protobuf runtime crate: ```rust enum OptionalField { Set(T), // T is the set value Unset(T), // T is the default value } ```...

I like this last proposal. I also think adding a flag or magic comment to generate getters that will return default values is also a good idea.