nvim-lspconfig icon indicating copy to clipboard operation
nvim-lspconfig copied to clipboard

feat: add dagger CUE lsp

Open marcosnils opened this issue 3 years ago • 5 comments

Signed-off-by: Marcos Lilljedahl [email protected]

marcosnils avatar Jul 21 '22 20:07 marcosnils

https://github.com/mattn/vim-lsp-settings mentioned in https://github.com/dagger/daggerlsp/pull/72#issue-1314001216 is related for those that are still on vim. I use vim on my legacy workstation (Mac 2017) & nvim on my 2 newer workstations (Mac 2021 & Linux 2022).

gerhard avatar Jul 25 '22 09:07 gerhard

@sigmaSd apologies beforehand for the direct ping. Any chances to quickly review this? Should be straightforward to merge :pray:

marcosnils avatar Jul 25 '22 15:07 marcosnils

@marcosnils well I'm not a maintainer of this repo xD good luck though!

sigmaSd avatar Jul 25 '22 16:07 sigmaSd

whoop! my bad. @justinmk maybe can help here? We're about to announce the release our LSP this week and it'd be great to have this merged.

marcosnils avatar Jul 25 '22 16:07 marcosnils

I didn't directly use this patch — but was inspired by it.

I got it to work with the following configuration.

local lspconfig = require 'lspconfig'
local configs   = require 'lspconfig.configs'
local util      = require 'lspconfig.util'

if not configs.dagger then
  configs.dagger = {
    default_config = {
      cmd = { 'dagger', 'cuelsp' },
      filetypes = { 'cue' },
      root_dir = function(fname)
        return util.root_pattern( 'cue.mod', '.git' )( fname )
      end,
      single_file_support = true,
      settings = {}
    },
  }
end
lspconfig.dagger.setup { }

tdjordan avatar Jul 28 '22 06:07 tdjordan

@lithammer @justinmk is there a way we can help to get this merged? I see other newer PR's get approved / merged and so far we haven't received any inputs on this one :pray:

marcosnils avatar Aug 01 '22 13:08 marcosnils

There's some formatting (Stylua) issues.

lithammer avatar Aug 01 '22 20:08 lithammer

There's some formatting (Stylua) issues.

that's unrelated to our changes. GA is complaining due to some dartls configs which have not been modified in this PR. Maybe a previous PR has been merged with failing CI?

marcosnils avatar Aug 01 '22 20:08 marcosnils

There's some formatting (Stylua) issues.

that's unrelated to our changes. GA is complaining due to some dartls configs which have not been modified in this PR. Maybe a previous PR has been merged with failing CI?

Right, sorry. I clearly wasn't looking very carefully 😓

lithammer avatar Aug 01 '22 20:08 lithammer

Right, sorry. I clearly wasn't looking very carefully

no worries. Thx for merging :hugs:

marcosnils avatar Aug 01 '22 20:08 marcosnils