node-client icon indicating copy to clipboard operation
node-client copied to clipboard

Published 20 hours ago • verified publisher icon neovim

deps: use msgpackr

Open justinmk opened this issue 2 years ago • 2 comments

Evaluate if it's worth switching to https://www.npmjs.com/package/msgpackr instead of our current msgpack dependency.

  • See https://github.com/neovim/node-client/pull/207#issuecomment-1637067789
  • Previous: https://github.com/neovim/node-client/issues/78
  • Related: https://github.com/vscode-neovim/vscode-neovim/issues/1316

justinmk avatar Jul 17 '23 22:07 justinmk

It appears that msgpackr does not support using 0 as an extension type code. https://github.com/kriszyp/msgpackr/issues/150

gjf7 avatar Oct 18 '24 16:10 gjf7

Thank you for mentioning that. Arg, I really wish we hadn't played with "extension types".

justinmk avatar Oct 18 '24 16:10 justinmk