neos-development-collection icon indicating copy to clipboard operation
neos-development-collection copied to clipboard

TASK: Improve NodeContentDimensionsInformation partial

Open dfeyer opened this issue 9 years ago • 13 comments

This change display the preset icon by default. With multiple dimension preset, the reading experience is better. The tooltip is also improved a bit and the styling of neos-label use now a little bit more padding around the text.

dfeyer avatar Aug 19 '16 10:08 dfeyer

@dfeyer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @aertmann, @MattiasNilsson and @hphoeksma to be potential reviewers

mention-bot avatar Aug 19 '16 10:08 mention-bot

I don't remember is we need to push the CSS files (currently my local SASS build tools a pretty broken)

Screenshot for the padding difference:

Before: Before

After: Before

dfeyer avatar Aug 19 '16 10:08 dfeyer

The CSS is built by Jenkins…

kdambekalns avatar Aug 23 '16 11:08 kdambekalns

@dfeyer woudl you vote yourself, then we can merge IMHO

kitsunet avatar Aug 30 '16 09:08 kitsunet

@dfeyer: marked as WIP feel free to adjust that css thing and then we can merge..

aertmann avatar Sep 08 '16 20:09 aertmann

Fix @aertmann comments, and retarget to master as this is not a bugfix

dfeyer avatar Nov 03 '16 14:11 dfeyer

@aertmann Fixed the styling issue ... stupid copy paste

dfeyer avatar Nov 04 '16 13:11 dfeyer

Thanks for the review @aertmann I just fixed your comment

dfeyer avatar Dec 05 '17 18:12 dfeyer

@daniellienert or @aertmann: Can you take care of the merge conflict?

jonnitto avatar Nov 12 '18 14:11 jonnitto

@daniellienert @aertmann @dfeyer ping last call to get this into 4.2 :)

bwaidelich avatar Nov 15 '18 11:11 bwaidelich

Last call for Neos 4.2 @daniellienert @aertmann @dfeyer

jonnitto avatar Nov 27 '18 12:11 jonnitto

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

stale[bot] avatar May 30 '19 01:05 stale[bot]

This issue has been automatically closed because it has not had activity for some time. But that does not need to be final. If you find the time to work on it, feel free to open it again. Thanks again for your contributions!

stale[bot] avatar Jun 13 '19 02:06 stale[bot]