neodash
neodash copied to clipboard
Fix/715 expand loses node text #715
#715
Added a boolean additive to control when to default the selections to the old selection first before proceeding with getting the other selections based on fields.
Maybe I can remove the boolean and have the getSelectionBasedOnFields function to always initially use the oldSelection first? For example, I expand a node on the graph report that reveals new labels > I set selections for new labels > I trigger rerun of the graph report's query from another Card. If those nodes with the new labels I recently set selections for come back, I'd expect those selections to persist. In this case, I should also have to pass in true for additive in the setSchema arguments in Report.tsx:populateReport function. Are there any situations where getSelectionBasedOnFields shouldn't default to oldSelection first?
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
2.3% Duplication on New Code