neo4j-graphql-js icon indicating copy to clipboard operation
neo4j-graphql-js copied to clipboard

Remove spaces from generated scopes

Open mayrmax opened this issue 6 years ago • 2 comments

Generated scopes contain a space in their name. By standard scopes are sent to the backend as a space separated list. See RFC 6749

This change removes the spaces from generated scopes and allows standard handling by existing libraries.

This breaking change as old scopes would not work anymore.


I'm not sure how others handled this I saw some solutions that separate scopes by colons but this would make it standard compatible.

mayrmax avatar May 31 '19 15:05 mayrmax

Codecov Report

Merging #258 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #258   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files           4        4           
  Lines         326      326           
=======================================
  Hits          308      308           
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 72e3276...9d83de9. Read the comment docs.

codecov-io avatar May 31 '19 15:05 codecov-io

https://github.com/neo4j-graphql/neo4j-graphql-js/issues/608

michaeldgraham avatar May 02 '21 04:05 michaeldgraham