spatial icon indicating copy to clipboard operation
spatial copied to clipboard

Published 20 hours ago • verified publisher icon neo4j-contrib

upgrade to current geotools (22.1)

Open stevenleadbeater opened this issue 5 years ago • 11 comments

All tests are passing and I have loaded the jars from the zip file to a geoserver war for current geoserver and added a neo4j data source without errors being thrown

stevenleadbeater avatar Dec 27 '19 09:12 stevenleadbeater

:+1:

you might want to change "oraclejdk8" in

https://github.com/neo4j-contrib/spatial/blob/df8d737d1a2e6821e19087efd2f3350aacd4eab6/.travis.yml#L2-L4

to "openjdk8" as Oracle is no longer available in the default/current build images due to EOL / Paid maintainance

mprins avatar Dec 27 '19 13:12 mprins

openjdk8

done

stevenleadbeater avatar Dec 27 '19 13:12 stevenleadbeater

I've had to fix some further issues on this, it appears as though GeoServer now loads the database location in as a URI which was confusing the location of the database on disk. This is now resolved and I have loaded up layers from the TestDynamicLayers class in GeoServer and successfully previewed them as OSM

stevenleadbeater avatar Jan 02 '20 14:01 stevenleadbeater

fixes #275 and #360

stevenleadbeater avatar Jan 02 '20 19:01 stevenleadbeater

Hi Steven. Thanks for this great contribution. I'd love to review and merge it, but we need to handle a tiny bit of paperwork first. Have you signed the CLA agreement described at https://neo4j.com/developer/cla/. It is a simple IP sharing agreement that we require to accept contributions. Normally it simply involves sending an email, so read the above link and send the email. Then I can look at merging this PR.

craigtaverner avatar Mar 20 '20 11:03 craigtaverner

Thanks @craigtaverner , I've sent the email

stevenleadbeater avatar Mar 31 '20 09:03 stevenleadbeater

Hi @stevenleadbeater, I've not seen the email yet. Can you verify that you sent it to the right address?

craigtaverner avatar Apr 01 '20 15:04 craigtaverner

I sent it to [email protected], is that not right? @craigtaverner

stevenleadbeater avatar Apr 02 '20 10:04 stevenleadbeater

That should have worked, and I see emails to that address working as recently as last week. Can you perhaps retry to [email protected] instead? That is the current official address.

craigtaverner avatar Apr 02 '20 13:04 craigtaverner

Thanks @craigtaverner I've sent that through

stevenleadbeater avatar Apr 02 '20 13:04 stevenleadbeater

This is strange. I've received cla emails as recently as an hour ago, but nothing from you. I'll check with others at this end to see what is happening. In the meantime, can you join neo4j-users.slack.com so we can DM and discuss how to resolve this. I think github issue comments are not the right forum for that.

craigtaverner avatar Apr 03 '20 09:04 craigtaverner