stash-pullrequest-builder-plugin icon indicating copy to clipboard operation
stash-pullrequest-builder-plugin copied to clipboard

Published 20 hours ago • verified publisher icon nemccarthy

Added options to mark a pull request as Approved or Needs Work

Open tettaji opened this issue 8 years ago • 13 comments

When set, this automatically marks a pull request as Approved or Needs Work if a build succeeds or fails, respectively.

tettaji avatar Apr 12 '17 15:04 tettaji

@tettaji nice PR! Thank you for the work.

@nemccarthy Hi Nathan. Do you think this PR can be merged into main branch? If not, what can be improved on to get it merged?

It would definitely help push Jenkins as more of an authority on our builds if it could set PRs to needs_work when the code breaks the build.

nitrocode avatar Nov 06 '17 11:11 nitrocode

👍 I verified this PR in our Jenkins instance, it works like a charm.

missedone avatar Nov 06 '17 13:11 missedone

@tettaji do you mind squashing commits in this PR so it's easier to cherry-pick?

Macarse avatar Nov 06 '17 21:11 Macarse

Thanks for the comments!

@Macarse sure, I've just squashed everything into one commit.

tettaji avatar Nov 07 '17 12:11 tettaji

When this can be merged?

dawidmalina avatar Jan 27 '18 22:01 dawidmalina

It would be cool if this could be merged before its one year anniversary. :P

tettaji avatar Mar 29 '18 15:03 tettaji

hehe I ended up forking and use my own version by cherry-picking what I need.

Macarse avatar Mar 29 '18 16:03 Macarse

oh man still open? congrats to a pullrequest which is 16months open @nemccarthy

phschoen avatar Jul 09 '18 09:07 phschoen

Unmaintained repo, unrelated to the Jenkins Project FYI. See https://github.com/nemccarthy/stash-pullrequest-builder-plugin/issues/158

batmat avatar Jan 21 '19 14:01 batmat

@batmat thanks for the heads up.

I haven't been using Jenkins for a while, but if anyone wants to fork this PR and submit it to the officially maintained repo, feel free to do so.

tettaji avatar Jan 21 '19 14:01 tettaji

@jakub-bochenski would be nice if you could take over this pull request as @tettaji have no more interest in doing it. But he is ok with taking his code.

dawidmalina avatar Feb 07 '19 17:02 dawidmalina

@dawidmalina I don't plan to work on this.

You can file a PR on https://github.com/jenkinsci/stash-pullrequest-builder-plugin/ if you want this integrated. One thing I would ask for if you do is some more context for this change. Right now I don't see why would one need this instead of just requiring a passing build to merge a PR.

jakub-bochenski avatar Feb 07 '19 19:02 jakub-bochenski

I have an interest, I'll try add the PR to the jenkinsci version of this repo

mrdima avatar Mar 13 '19 10:03 mrdima