Nejc Habjan

Also note to self: Just noticed this package no longer has a public API. So I guess this functionality should actually go into https://github.com/CycloneDX/cyclonedx-python-lib, if we as users want to...

@jkowalleck sure, this was mostly for internal use to display the SBOM angular-style, will ensure it's encoded before going upstream! Thanks for the hint there, since some license contents start...

Thanks for the report @ramarro123. Seems like the `gitlab project-merge-request-approval-rule create` is buggy currently because we have a custom `create()` method for this API, and the auto-generated CLI client doesn't...

@lmilbaum this should also help get rid of `requests.HTTPBasicAuth` for the backend migration, as I just pass a generic tuple in here when used. Both httpx and requests accept tuples.

@gdubicki thanks for the feedback! I'll take another look at what wording makes the most sense, especially when compared to `requests`/`httpx` and similar underlying libraries. For context, this `decode()` method...

Maybe an additional `.text()` really is more explicit. It's 2 totally different kinds of `decode`s we're calling so maybe we shouldn't mix them. I'll rework this a bit :)

Thanks for the issue @zampierilucas! We already have the `/approval_rules` endpoint so users have had a way to migrate for a while: https://github.com/python-gitlab/python-gitlab/blob/348f56e8b95c43a7f140f015d303131665b21772/gitlab/v4/objects/merge_request_approvals.py#L161-L162 So the only thing we can maybe...

Thanks! Let's keep it open so we can remove the update now rather than later so we don't wonder at some point why we have that :sweat_smile:

Looks like we have some old code here: https://github.com/python-gitlab/python-gitlab/blame/eb54adf2fe7d3c68dcb6021065e51ba33b7bbc04/gitlab/v4/objects/merge_request_approvals.py#L155 We might be able to just get rid of that custom save method, things might be more consistent these days. I...

Thanks @zapp42, I'll admit the maintainers here never had a use case for this and the new methods were just a port of the old deprecated ones. I'd be happy...