neetcode-gh
Sri Hari: Neetcode-150/added-5-articles
Created articles
- Took roughly (5 hours 30 min) for this work.
- There are more than 2 solutions in each article.
-
- Please review this Navi.
Thanks @Srihari2222 great work! Just some very minor feedback:
I think it's worth adding a description for time complexity variables when we have multiple variables. For example, in anagram-groups, I assume m is the number of strings and n is the length of the longest string, but we should explicitly mention it. You can use a similar format i did here: https://github.com/neetcode-gh/leetcode/blob/main/articles/course-schedule.md
Also, in the future you can directly assign me as the reviewer in github.
Thanks for the feedback, you can mention more if needed as I am making the changes you mentioned.
I added the changes you mentioned and also I didn't add description in top-k article though the time complexity is nlogk because k is directly mentioned in code. Whats your opinion on this?
@Srihari2222 Thanks, looks good! I think it might be better to also add it for top-k, since then we can explicitly mention that n is the length of the input. It's minor though, I will merge this pull request as-is. If you wanna make more changes feel free to add them in a separate PR.
I will be reviewing your future contributions less carefully, so i'll trust your judgement on those. Thanks again!
@Srihari2222 Also, in the future could you tag me @neetcode-gh in your comments. I currently have github notifications off by default so this will help me respond more quickly.