coveragepy icon indicating copy to clipboard operation
coveragepy copied to clipboard

956 package tree report

Open tim-mitchell opened this issue 5 years ago • 5 comments

implements #956 Tests on 3.6 are passing. I have run it on python 2.7 but not the tests as pip will not install dependencies due to ssl errors. On 2.7 only tests/test_html.py::HtmlGoldTests::test_bom is failing but I can't figure out why.

tim-mitchell avatar Mar 19 '20 22:03 tim-mitchell

Codecov Report

Merging #961 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #961      +/-   ##
=========================================
+ Coverage   94.09%   94.1%   +0.01%     
=========================================
  Files          86      86              
  Lines       12089   12182      +93     
  Branches     1210    1228      +18     
=========================================
+ Hits        11375   11464      +89     
- Misses        580     582       +2     
- Partials      134     136       +2
Impacted Files Coverage Δ
coverage/html.py 100% <100%> (ø) :arrow_up:
tests/test_arcs.py 98.51% <0%> (-1.49%) :arrow_down:
coverage/xmlreport.py 100% <0%> (ø) :arrow_up:
tests/test_xml.py 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa2e0e4...b0276bd. Read the comment docs.

codecov-io avatar Mar 20 '20 01:03 codecov-io

The tests are currently failing with:

Traceback (most recent call last):
  File "/Users/ned/coverage/trunk/.tox/py36/bin/coverage", line 11, in <module>
    load_entry_point('coverage', 'console_scripts', 'coverage')()
  File "/Users/ned/coverage/trunk/coverage/cmdline.py", line 827, in main
    status = CoverageScript().command_line(argv)
  File "/Users/ned/coverage/trunk/coverage/cmdline.py", line 597, in command_line
    **report_args
  File "/Users/ned/coverage/trunk/coverage/control.py", line 929, in html_report
    return reporter.report(morfs)
  File "/Users/ned/coverage/trunk/coverage/html.py", line 244, in report
    self.merge_single_folders()
  File "/Users/ned/coverage/trunk/coverage/html.py", line 430, in merge_single_folders
    self._merge_branch_folders(tree_info)
  File "/Users/ned/coverage/trunk/coverage/html.py", line 436, in _merge_branch_folders
    path, child_info = next(iitems(tree_info['children']))
TypeError: 'dict_items' object is not an iterator

I wanted to try running this code to see the report that was generated, but I also get this error.

nedbat avatar Mar 29 '20 21:03 nedbat

Sorry about that - I was not being careful with my code tidying

tim-mitchell avatar Mar 29 '20 21:03 tim-mitchell

Thanks for fixing the error. I don't understand why the indentation is off though? When I run this on coverage itself (with ARGS="-e py36" make clean metacov metahtml), I get: image

nedbat avatar Apr 01 '20 18:04 nedbat

Me neither. I couldn't figure it out so I raised in issue upstream https://github.com/kanety/jquery-simple-tree-table/issues/8

tim-mitchell avatar Apr 01 '20 19:04 tim-mitchell

It seems neither of us have the energy to make this happen. How about closing this PR?

tim-mitchell avatar Oct 06 '22 21:10 tim-mitchell

Maybe someday...

nedbat avatar Oct 06 '22 22:10 nedbat