coveragepy
coveragepy copied to clipboard
nedbat
WIP type annotations
Very WIP
Contains:
- partial type annotations for some modules
- github workflow integration
addresses: #1434
I haven't looked at this closely, but do you have a way to run mypy as part of the tools?
I haven't looked at this closely, but do you have a way to run mypy as part of the tools?
I'm unfamiliar with your project configuration (make, pip-compile) but I can give it a go.
Thanks for taking this all on. I added some details to the Contributing section of the docs about dependencies and make upgrade, though I wonder if I've added enough? Can you take a look and let me know? Thanks so much.
What is the future of this pull request? It might be too hard to get everything type-checked, since the master branch is continuing development. Is there a way to get the tooling in place, and gradually make progress on adding the annotations?
Hmm, sure. I could clean this up and get a minimal state ready to merge when I get time.
What is the future of this pull request? It might be too hard to get everything type-checked, since the master branch is continuing development. Is there a way to get the tooling in place, and gradually make progress on adding the annotations?
@nedbat On uvicorn, we created an issue to track our progress: https://github.com/encode/uvicorn/issues/998.
Each PR had an entry on the mypy configuration file (setup.cfg for us).
I can create a similar issue for coverage, and help to coordinate, if wanted.
I started a more gradual approach. As of 212f6520, four files on master are checked with mypy. I'd be happy to have help adding more files gradually, and eventually making the checks more strict and complete. I'll close this PR now, but feel free to re-open it if you can make this way work with the latest code.
As of now (commit b059a67f), all of the files in coverage/ and tests/ are checked by mypy.