coveragepy icon indicating copy to clipboard operation
coveragepy copied to clipboard

fix(html): trigger filter on page load

Open marc-legendre opened this issue 3 years ago • 1 comments

In the HTML report, if the "filter" input contains a value when the page loads (e.g. when refreshing the page), it is ignored. This happens even though an event is actually created on start-up to trigger the refresh.

I believe this is a regression introduced in 9a1954a224c7c0f578513d8f4ca5f821fcf2cf5a, when the observed events changed from "keyup change" to "input".

Therefore this PR changes the type of the fired event to match the type of the observed events.

marc-legendre avatar Jun 27 '22 15:06 marc-legendre

Hello @nedbat,

Here is a possible a fix to a minor issue I stumble upon in the HTML report.

What do you think of this PR?

(Also, thank you for your work on this project :))

marc-legendre avatar Jul 23 '22 20:07 marc-legendre

Thanks!

nedbat avatar Aug 06 '22 18:08 nedbat

This is now released as part of coverage 6.4.3.

nedbat avatar Aug 06 '22 20:08 nedbat