terminal.land icon indicating copy to clipboard operation
terminal.land copied to clipboard

Published 20 hours ago • verified publisher icon neatnik

Automate Electron builds/releases

Open neatnikbot opened this issue 5 years ago • 2 comments

Automate Electron builds/releases

__

This issue was submitted by Adam (https://compendium.terminal.land/person/Adam)

neatnikbot avatar Oct 10 '20 17:10 neatnikbot

First strides taken in #120.

Remaining issues per @newbold:

  1. Any idea how to only have the action fire when something is pushed to /clients/electron, vs. on any commit elsewhere?
  2. When I build locally I’m signing my Windows releases with an Authenticode code signing certificate, so I need to figure out how to bring that into this process.
  3. I have an existing script that handles the macOS notarization—need to see if the Action can somehow run that as well.

k7hpn avatar Dec 03 '20 07:12 k7hpn

The first Item should be addressed in #122 Only build Electron if Electron files are modified.

For items 2 and 3, I think the easiest way to manage it will be following the Code Signing instructions that go with this GitHub action, the certificates can be extracted, Base64 encoded, and put into GitHub project secrets. Then the Action's configuraiton can be updated to use them. That link provides instructions on doing so for the Mac certificate, I'm assuming the procedure is similar for the Windows one?

k7hpn avatar Dec 04 '20 03:12 k7hpn