hlint icon indicating copy to clipboard operation
hlint copied to clipboard

Published 20 hours ago • verified publisher icon ndmitchell

generalize zip on empty lists hint

Open jvoigtlaender opened this issue 1 year ago • 4 comments
trafficstars

Will the notEq x [] in the side condition work as intended, or is extra "escaping" of the list brackets necessary as in lhs and rhs?

jvoigtlaender avatar Feb 04 '24 20:02 jvoigtlaender

What's notEq?

googleson78 avatar Feb 04 '24 22:02 googleson78

The hlint-internal side condition combinator that is already used at various other places in the same file.

jvoigtlaender avatar Feb 04 '24 22:02 jvoigtlaender

The notEq looks fine. However, you have also used isNonEmpty. As far as I can tell, that hasn't been in hlint for many years. Yes, there was a use of it. But no, it didn't do anything, so I've deleted it. Can you remove the isNonEmpty uses.

ndmitchell avatar Aug 26 '24 15:08 ndmitchell

Done.

jvoigtlaender avatar Aug 26 '24 16:08 jvoigtlaender