ScoutSuite
ScoutSuite copied to clipboard
nccgroup
Publish container to GitHub Container Registry
Now that the GitHub Container Registry is in public beta (https://github.blog/2020-09-01-introducing-github-container-registry/), we could publish our new image to that registry, instead of relying on docker hub.
That would allow us to automate publishing the container and should be easier to maintain.
I don't see any reason why we shouldn't do this.
I would still suggest publishing to docker hub as well though.
Agreed.
On Sun, Sep 13, 2020, 04:26 Thomas Morledge [email protected] wrote:
I don't see any reason why we shouldn't do this.
I would still suggest publishing to docker hub as well though.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/nccgroup/ScoutSuite/issues/855#issuecomment-691634785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYKFNAN65JBEJR2XHSMZTSFR63DANCNFSM4RKQY7NQ .
I'm not up to scratch with GitHub actions but it looks fine to me. I'll let @rossja give their thoughts before I mark it as reviewed.
Unfortunately, The automatically generated GITHUB_TOKEN will not work for authentication for the initial release. It will require creating the ghcr.io/nccgroup/scoutsuite:latest manual for the first time.
docker login -u ${GITHUB_NAME} -p ${GITHUB_TOKEN} https://ghcr.io
docker push ghcr.io/nccgroup/scoutsuite:latest
sorry for the loooong delay on this. had a lot going on. working through the backlog now.
annnnd...it's been forever. sorry. working through this now. one reason for the long delay is that i've been looking into completely restructuring the way the docker images work to significantly reduce the size of the image (right now it's ~4gb). planning to create separate images for each of the clouds (aws, azure, ibm, etc.) rather than the all-in-one that we currently use.
@rossja Would it be possible to publish the version 5.12.0 to DockerHub, the current version is 5.11.0
@Techbrunch. yep. i'll build out today. I've completely reworked how the docker stuff builds, and am ready to merge it in, but need to figure out the best way to do that because so much changed for it. (Part of that change is also to number the dockerhub images based on the version of Scoutsuite they include, btw).
@rossja How can I use the new image ? I see that you pushed base-latest 17 days ago but base was last pushed 4 month ago ?
@Techbrunch : good catch! i had a bug in my tag script, so was naming everything into separate repositories rather than the ncc-scoutsuite one. i've fixed that now and have pushed the updates to the right spot.
@rossja am I looking in the wrong place ? I'm still seeing the old version here: https://registry.hub.docker.com/layers/rossja/ncc-scoutsuite/latest/images/sha256-4455369d7eeb53bb840facd67e0adc6426d5166bcfaf2a4e378082a4e40dafa7?context=explore
ah! yeah, that should go to ncc-scoutsuite:base-latest. i didn't update ncc-scoutsuite:latest to point to that in the tags when i restructured. i've added that to the tag script now -- but it will have the potentially unexpected side effect of NOT including aws by default (aws is in ncc-scoutsuite:aws-latest, same with the other respective clouds).