Nicholas Blumhardt

Results 927 comments of Nicholas Blumhardt

I'll close this one as it adds some complexity, and triggered a failure in CI; if there's a good case to pick it back up sometime just let me know....

Thanks for dropping us a line! How does the duration you want to pass through the `IDiagnosticContext` differ from the one computed by the middleware?

Ah sorry, I see I misunderstood 😅 - thanks for the clarification.

Thanks for the note. Dealing with `LoadFrom()` isn't always straightforward, so I'm not sure we'll want to attempt it directly in this project. Your best bet is to use the...

https://github.com/serilog/serilog-settings-configuration/issues/406#issuecomment-1878440317

Thanks for sending this one. MailKit has rather a lot of configuration options, I'm wondering whether, instead of adding all of these, the `Options` type in this project might just...

Thanks for the suggestions! I think where possible, we should lean on Serilog's existing functionality for dynamic tasks like filtering or parameterisation. For example, returning a `bool` from the callback...

Hi @Meligy, nice to hear from you :wave: Is this a potential improvement to `dotnet watch`, i.e. ignoring ANSI escape sequences when looking for the `Now listening on:` log line?...

Thanks for the heads-up! Serilog.Enrichers.Sensitive has a now-obsolete workaround to make its default options constructor callable: https://github.com/serilog-contrib/Serilog.Enrichers.Sensitive/blob/master/src/Serilog.Enrichers.Sensitive/SensitiveDataEnricherOptions.cs#L24 Although the constructor accepts `operators`, the value is thrown away. Now that Serilog.Settings.Configuration...

Odd! I'm not sure where this could be happening - would be great to track it down. Setting up a unit test in the `serilog/serilog` project for the `MessageTemplateTextFormatter` class...