Nicholas Blumhardt
Nicholas Blumhardt
Thanks @ewoutkramer - those look like reasonable modifications, I'll take a look at this.
Looking at this again, I wonder if we should consider just making all the `internal` properties and constructors on `Result` (and `TokenListParserResult`) public 🤔 I originally steered away from this...
Thanks for the suggestion! This is also being discussed in: https://github.com/datalust/seq-tickets/issues/832 - we're keen to make this kind of thing available to all inputs, so we'll probably aim to do...
This now works :+1:
👍 both angles are definitely valid. The current shape of these APIs has been stable for quite a long time now, so I'm leaning more towards favouring completeness and consistency...
Thanks for this Ewout. I was wondering - in the `TokenizerBuilder` case, I can't see where we'd actually make use of the backtracking flag - I think it's just being...
Interesting - makes sense! Thanks for the details. I agree that being able to base code off of the internal implementations would be worthwhile 👍 I need some time to...
Thanks for the PR! Is there anywhere currently in the code path that we'd expect this to speed up? Also, especially if so, should we first consider making these types...
Hi! Thanks for your reply. Giving this some thought, it would probably be a bug if we were using struct equality implicitly anywhere in this codebase, so adding support for...
Hi @ewoutkramer! Alas, I haven't had any time to loop back here. I'm working in a fairly distant part of the stack at the moment, so getting back up to...