Nicholas Blumhardt
Nicholas Blumhardt
Thanks for the note. This is by design, but I can see where it could be surprising. To mark your HTTP request logger, though, rather than use `ForContext` (which the...
Thanks for the thoughtful reply; I can see how this is awkward. Creating a whole new logging pipeline for the middleware that applies levelling and forwards to the "main" logger...
Thanks for the write-up and suggestion. I'm not actively using this sink so something of a caretaker right now, and not sure what would be involved in implementing this. If...
Does anyone have comparative perf numbers for performing the level check in case-insensitive vs sensitive mode? I think that's the place we're most likely to hit issues. I don't think...
Thanks for the follow-up @tillig. I think there's a bug in the current version, that `StartsWith()` should really be specifying `StringComparison.Ordinal`. I think we'd be comparing the ordinal vs ordinal-ignore-case...
Awesome, thanks for doing this @tillig. It's a bit tricky to draw precise conclusions from the benchmark because it mixes results from a variety of cases (some where the logger...
Hi @migajek; thanks for raising this. `LogEventReader` is part of _Serilog.Formatting.Compact.Reader_, which this package doesn't depend on or use; unfortunately it's a Serilog component and will likely only work when...
That makes sense - thanks @migajek. Does need some more thought at our end :+1:
@agocke just thinking about: > I should also mention -- it's worth considering if this space should have an AOT-compatible solution. I think a source generator would probably be necessary....
Thanks @jimbojim1997! This looks good, even if the need for the second tuple member to be `object?` is a bit awkward, it's an improvement on the dictionary approach and we...