Nicholas Blumhardt

Results 936 comments of Nicholas Blumhardt

Great! It looks like there are still some problems to resolve - ``` C:\projects\serilog\src\Serilog\Settings\KeyValuePairs\SettingValueConversions.cs(33,20): error IL2026: Using member 'System.Type.GetType(string, bool)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code....

Hi folks! I think this issue is stale - category names were routed into `InstrumentationScope.Name` in #4941.

Hi @Falco20019; it sounds like your scenario is covered by https://github.com/nblumhardt/serilog-redaction - let me know if this does the trick for you.

Hi! Thanks for the follow-up. For comparison, why would you not: 1. Create an `IDestructuringPolicy` implementation for your target types that ignores the "hidden" properties, and, 2. Use redaction to...

Thanks @Falco20019. Although we could implement the kind of thing you're suggesting, it'd still be trivial to bypass: ```csharp // Any type that implements `ToString()` by calling `ToString()` on its...

Hi! Sorry about the slow turnaround, a bit buried this past week. I sympathize with where you're stuck, but I think https://github.com/serilog/serilog/issues/2023#issuecomment-1988038143 is accurate - an optimal solution requires some...

Hi! You don't happen to be using the _Serilog.Exceptions_ package, by any chance?

That's the one; however that's being referenced, it'll be configured in your logging pipeline and is responsible for the `ExceptionDetail` property/data on the resulting events.

Just circling around to the linked issue :-) ... would the end result be better/worse for Akka.net depending on whether we push that one forward?

I think this is doable, but we'd have to be careful about how we handle any exceptions captured by `IDiagnosticContext` (`collector`, in the middleware code), since those won't propagate and...