egjs-flicking icon indicating copy to clipboard operation
egjs-flicking copied to clipboard

Published 20 hours ago • verified publisher icon naver

refactor: declare methods in methods instead of created

Open malangfox opened this issue 2 years ago • 2 comments

Issue

#770

Details

This changes getPanels and getVirtualPanels to be initialized in methods instead of created. In some cases, such a warning appears because the methods declared in created are not recognized.

malangfox avatar Mar 17 '23 09:03 malangfox

Coverage Status

Coverage: 79.337% (+0.1%) from 79.233% when pulling 15dae4035a683eabb96808ee6654fa937c66db13 on malangfox:refactor-vue3-methods into 761aa929d0a367442e4fcc867bf4c7ea92598241 on naver:master.

coveralls avatar Mar 17 '23 09:03 coveralls

LGTM

@malangfox Check if this is the case in vue2 as well.

daybrush avatar Mar 20 '23 02:03 daybrush