k8s icon indicating copy to clipboard operation
k8s copied to clipboard

Nats Nack missing k8s components.

Open BenCoughlan15 opened this issue 3 years ago • 2 comments

Hey there!

I've deployed nats-nack, but I can see it's missing the following important components.

RESOURCES:

not that it uses a whole pile, but it would be good to have a handle on this, with sensible defaults.

  • limits.cpu
  • limits.memory
  • requests.cpu
  • requests.memory

PROBES:

pretty important for health checks, etc.

  • livenessProbe
  • readinessProbe

REPLICAS:

ideally more than one, or have a PDB that would ensure its running.

  • replicas

I guess my questions are:

  • Are there any plans to add these?
  • Should I knock together a PR?
  • Is nats-nack still the correct tool to use for account/stream/consumer management?
  • Would you recommend something else?

BenCoughlan15 avatar Aug 09 '22 14:08 BenCoughlan15

Happy to accept a PR that sets these defaults 👍

wallyqs avatar Aug 09 '22 14:08 wallyqs

Since Go 1.19 has been I think we can start adding these limits, we also should apply GOMEMLIMIT so that limits.memory actually works for the Go GC.

wallyqs avatar Sep 02 '22 16:09 wallyqs