k8s
k8s copied to clipboard
Nats Nack missing k8s components.
Hey there!
I've deployed nats-nack, but I can see it's missing the following important components.
RESOURCES:
not that it uses a whole pile, but it would be good to have a handle on this, with sensible defaults.
- limits.cpu
- limits.memory
- requests.cpu
- requests.memory
PROBES:
pretty important for health checks, etc.
- livenessProbe
- readinessProbe
REPLICAS:
ideally more than one, or have a PDB that would ensure its running.
- replicas
I guess my questions are:
- Are there any plans to add these?
- Should I knock together a PR?
- Is nats-nack still the correct tool to use for account/stream/consumer management?
- Would you recommend something else?
Happy to accept a PR that sets these defaults 👍
Since Go 1.19 has been I think we can start adding these limits, we also should apply GOMEMLIMIT so that limits.memory actually works for the Go GC.